fix: Update notification popup icon styles to account for showing state #12033
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Icons in the omnibox indicate pending actions (e.g., password save modal) and should remain visible until the user completes or rejects the action. When a modal is dismissed, JS keeps showing=true on the icon, but Zen wasn't accounting for this and hid the icon with opacity: 0 while keeping it clickable. This also blocked clicks to icons positioned underneath.
dosubot
bot
added
size:XS
mr-cheffy
requested changes
Jan 26, 2026
| } | ||
|
|
||
| #notification-popup-box:not([open]) { | ||
| #notification-popup-box:not([open]):not(:has(> [showing="true"])) { |
Member
There was a problem hiding this comment.
I don't really like the use of :has, is there no other way this could be done? Maybe we should apply these styles to the icons inside, instead of the entire notification-popup-box. So, for example, #notification-popup-box:not([open]) <element>:not([showing="true"]) {}
Contributor
Author
There was a problem hiding this comment.
Yeah I don't either. It was the only approach that I could think of that would allow now writing rules for every single element.
I'm not familiar enough with Firefox's urlbar to know what icons are supposed to have this behavior other than the password one, I don't think I have encountered any other yet. Selecting only the password element sounds like it'd work for me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11870
Icons in the omnibox indicate pending actions (e.g., password save modal) and should remain visible until the user completes or rejects the action.
When a modal is dismissed, JS keeps showing=true on the icon, but Zen wasn't accounting for this and hid the icon with opacity: 0 while keeping it clickable.
This also blocked clicks to icons positioned underneath.
zen_fix_pw_omnibox_remux_h265.mp4