Add Firefox Sync support for workspaces, folders, and pinned tabs #12063
+1,420
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:L
mr-cheffy
approved these changes
Jan 27, 2026
src/zen/folders/ZenFolders.mjs
Outdated
|
|
||
| // Notify sync engine if pinned/essential tab was moved to folder | ||
| if (group.isZenFolder && (tab.pinned || tab.hasAttribute("zen-essential"))) { | ||
| Services.obs.notifyObservers(null, "zen-pinned-tabs-changed"); |
Member
There was a problem hiding this comment.
These notifiers should be called from ZenWindowSync imo
src/zen/workspaces/ZenWorkspaces.mjs
Outdated
| window.dispatchEvent(new CustomEvent("ZenWorkspaceDataChanged"), { bubbles: true }); | ||
| window.gZenWindowSync.propagateWorkspacesToAllWindows(aSpaceData ?? this._workspaceCache); | ||
| // Notify sync engine of workspace changes | ||
| Services.obs.notifyObservers(null, "zen-workspaces-changed"); |
Member
There was a problem hiding this comment.
Also call from the WindowSync manager
src/zen/tabs/ZenPinnedTabManager.mjs
Outdated
| // Only notify sync engine if tab is being unpinned, not closed | ||
| // When a tab is closing, it will be removed anyway, no need to sync | ||
| if (!tab.closing) { | ||
| Services.obs.notifyObservers(null, "zen-pinned-tabs-changed"); |
Member
There was a problem hiding this comment.
Also call from the WindowSync manager
…all locales" This reverts commit 7f8d764.
dosubot
bot
added
size:XXL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new Firefox Sync engine that syncs:
The sync is enabled by default when Firefox Sync is active. It uses a single-record approach similar to the Prefs engine, with last-writer-wins conflict resolution.
Key things:
The engine triggers sync on workspace changes, folder changes, pinned tab changes, tab moves, and folder icon updates.