fix: validate endpointOverride URI scheme (#626) #1758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Author
|
About the edge case discussion in #626
All real-world cases I could find use http:// or https://. Makes sense since AWS SDK communicates over HTTP(S). |
Add httpUri config descriptor that validates the URI scheme is http or https. This prevents runtime NullPointerExceptions when invalid URIs (e.g., 'minio:9000' without scheme) are passed to AWS SDK. Changes: - Add httpUri descriptor with scheme validation in descriptors/package.scala - Update commonAwsConfig to use httpUri for endpointOverride - Add tests for valid (http/https) and invalid (missing scheme) endpoints Fixes zio#626 Co-Authored-By: Claude Opus 4.5 <[email protected]>
darkenpeng
force-pushed
the
fix/626-endpoint-uri-validation
branch
from
8404bce to
40c9dbb
Compare
guizmaii
reviewed
Jan 27, 2026
| val httpUri: Config[URI] = Config.uri.mapAttempt { uri => | ||
| val scheme = uri.getScheme | ||
| if (scheme == null || (!scheme.equalsIgnoreCase("http") && !scheme.equalsIgnoreCase("https"))) { | ||
| throw new IllegalArgumentException( |
Member
There was a problem hiding this comment.
What's the type signature of mapAttempt. please?
I'm pretty sure it take a function URI => Either[String, A] and I'm pretty sure you're not supposed to throw
Author
There was a problem hiding this comment.
Thanks for the quick review! You're right — I've updated it to use mapOrFail with explicit Either instead.
Address review feedback - use explicit Either return instead of throwing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add
httpUriconfig descriptor that validates the URI scheme ishttporhttps. This prevents runtimeNullPointerExceptionwhen invalid URIs (e.g.,minio:9000without scheme) are passed to AWS SDK.Problem
When configuring
endpointOverridewith an invalid URI likeminio:9000(missing scheme), the config parsing succeeds but AWS SDK throws NPE at runtime.Solution
httpUridescriptor that validates scheme ishttporhttpsChanges
descriptors/package.scala: AddhttpUridescriptor with scheme validationCommonAwsConfigSpec.scala: Add tests for valid/invalid endpointsFixes #626