Skip to content

request(): Improve validation and allow/return more #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
AbeJellinek wants to merge 1 commit into
base: master
Choose a base branch
from
Open

request(): Improve validation and allow/return more #39

AbeJellinek wants to merge 1 commit into from

Conversation

@AbeJellinek
Copy link
Member

@AbeJellinek AbeJellinek commented Dec 4, 2024

  • Validate responseType - some underlying implementations may allow more values (arraybuffer), but we only support three when calling from a translator
  • Allow URL object as url argument
  • Accept successCodes
    • This was an oversight when originally implementing this function. Useful and we should support it!
  • Return statusText and responseURL for more complex use cases

@AbeJellinek AbeJellinek requested a review from dstillman December 4, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dstillman dstillman Awaiting requested review from dstillman

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@AbeJellinek