frontend: implement readFile function #149
Conversation
zombiezen
left a comment
zombiezen
left a comment
There was a problem hiding this comment.
Thank you! LGTM after one small comment. We should also document this function: mind sending a PR over to https://github.com/256lights/zb-docs/blob/main/lua/extensions.md ?
zombiezen
left a comment
zombiezen
left a comment
There was a problem hiding this comment.
I overlooked something, sorry:
|
No clue what’s up with that test failure; flaky test (as it passes on my machine)? |
|
Yeah, that's #135. Sorry for the noise. |
winterqt
force-pushed
the
push-znwkmtytxwzt
branch
from
18804bc to
7381385
Compare
|
Since you squash merge PRs, I just put every refactor back into this commit, but if you'd rather me split it, let me know. |
winterqt
force-pushed
the
push-znwkmtytxwzt
branch
from
7381385 to
bbe2f30
Compare
zombiezen
left a comment
zombiezen
left a comment
There was a problem hiding this comment.
Thanks for the refactor! LGTM after the suggestions below (I think you should be able to 1-click all these in).
That's fine. In general, I prefer just adding commits on top of the original so that the GitHub UI can show differences since last view. But as you note, it all gets squashed in, so it doesn't matter much. |
Co-authored-by: Roxy Light <[email protected]>
|
Should be good now. |
2 participants
Closes #148.