Sound Effect Fixes #207
Sound Effect Fixes #207
Conversation
I faded it out quicker and fixed some of the audio clipping. No need for it to be 19 seconds long considering what it's used for. No other changes made. I'm not partial to this sound effect, but at least the fidelity of it's better in case others like it still.
The audio starts and stops above and below zero amplitude, which means it causes popping and cut-out type of noise. So I just trimmed it to a zero-crossing on the waveform at beginning and end to fix it without modifying it elsewise. I'm not quite satisfied with this sound effect either, but it's at least not as immersion breaking now with the quality fix.
I did a lot of weird stuff in audacity to this to make it sound satisfying to me. It's not perfect, and it does have a more muffled tone to it, but I find it less jarring than the current one, personally. Adding it as an alternative since it's not a straight improvement or anything. It also uses another CC-SA sound effect mixed in to mitigate the clipping in the original somewhat, and I added some generated pink noise for like reasons. Like I said, lots of weird stuff I tried. Anyway, here's the other explosion sound effect added to it: Explosion 2.wav by theplax -- https://freesound.org/s/560577/ -- License: Attribution 4.0
|
Cool, you should put in the README.md in the |
Sure thing. Thanks for the heads up. |
|
I'm not sure where the drill sound effect comes from, but what I did is just a pop-fix for that too and don't need credit. CC0. Just small fixes here. We can ignore the TNT alt sound. Feedback is mixed to negative on it right now, and I'm fine with tossing it. But yeah, for the drill sound effect, I don't think it got credit in the readme originally: https://github.com/ChefZander/skyblock_zero/commits/master/?since=2024-11-01&until=2024-11-30&after=bb1faa2501e6f5c29c7d520d3baa657866a570a1+69 I'd like to come up with something else soon, so if we want to just wait on that, we can. I've put in a pull request for the Readme change on the annihilator sound effect pop fix anyhow, and I think it's a much more comfortable improvement to it. I was actually avoiding using it ingame or muting my audio because the pop was so grating to me. I'm a fussy person. |
I think i made the drill sound effect from reversing the matter annihilator sound and messing with it in audacity, i should've put this in the readme when i did it but i didnt know anything about licensing back then |
in hopes of a better one later that can replace the normal one, which has clipping issues.
Okay, no worries. I'll see what I can do and update the readme from here. Also figured out why the storinator click was delayed (audio file starts too early before the actual sound). I'll give you a heads up when I'm done fussing. Thank you for the support. :) |
|
Okay, I'm just going to call it here for simple fixes. And if you think the readme's too cluttered now, I don't mind not receiving any credit for the slight fixes. I feel like it might be good to just have this stuff in a different doc eventually since most players probably don't care (but I understand it's important to credit). |
|
|
|
wait. not yet |
README.md
Outdated
| - [SFX Hit] deep kick boom by waveplaySFX -- https://freesound.org/s/231349/ -- License: Attribution 4.0 | ||
| - block_annihilated.ogg, drill_dig.ogg: "[SFX Hit] deep kick boom" by waveplaySFX -- https://freesound.org/s/231349/ -- License: Attribution 4.0 | ||
| - pop fix for block_annihilated.ogg by AbbyRead: CC0 | ||
| - heavily edited for drill_dig.ogg by TheEt1234: all rights reserved derivative work (default state of it, as license was unspecified at the time) |
There was a problem hiding this comment.
i think its fine to just not specify licenses for modifications, as its assumed to be the same? im not sure on this but i assume that (and also i assume that when anyone contributes, their work is licensed under the same license, i don't know if those assumptions are correct)
but to make it clear i license drill_dig.ogg as CC-BY 4.0, it cannot be proprietary or the contentDB package would need to be marked as non-free
(im also not a lawyer so i dont know much about this)
There was a problem hiding this comment.
I think that's what the SA option is for (share alike), like how GPL has a clause that LGPL doesn't have where your modifications have to be the same license. I could be wrong, and it doesn't make use free and clear. My putting CC0 on my changes just means I don't mind if people disregard credit to me specifically. But if it makes it clearer (and I think it probably does now that you mention it), I can just mark it with the same license so that people don't get the wrong idea about how to use it and credit. Like it's definitely NOT stripping the original creator's right to credit, but people tend to just see one license specified and don't fallow a trail to be extra sure about legality. The whole rigmarole regarding licensing is really obtuse, and it's easy to think the complexity implies danger. I think with this stuff though, best effort is all we can do at the end of the day, and that has to be enough.
There was a problem hiding this comment.
Yeah, I think I'm just gonna strip my license info to make it clearer.
There was a problem hiding this comment.
As i understand it, the license of your/mine contributions is the license of the project, under github's TOS, so i hope there aren't issues here
There was a problem hiding this comment.
EDIT: unless you specify in your contribution otherwise, i think
There was a problem hiding this comment.
I read that as implying that any unspecified contributions from outside take the license of the repository. Like contributing code fixes actually revokes one's full copyright rights since it's implied that you're giving something over rather than licensing it out. Honestly though, I'm fine with whatever. Laws are just structured threats intended to mitigate unrest in a populous that doesn't cooperate by nature.
There was a problem hiding this comment.
so my issue was with this line
- heavily edited for drill_dig.ogg by TheEt1234: all rights reserved derivative work (default state of it, as license was unspecified at the time)
it shouldn't be
There was a problem hiding this comment.
No problem. I can just take that out.
There was a problem hiding this comment.
I had only put that in as a documentation based on what you stated in the thread, but that was precipitated by my own attempt at specifying what was used where. If it wasn't a problem before though, I'm just complicating things needlessly. Apologies. I've updated it to just include that as a mention of the source now for that file.
There was a problem hiding this comment.
If it wasn't a problem before though, I'm just complicating things needlessly. Apologies.
No, you can keep it, just don't make it say "all rights reserved"
you can just mention that i modified it (i think/vaguely remeber i modified it, i was a lot less knowledgeable on licensing back then)
(sorry for being annoying with licensing i just dont want to mess this up)
|
I just changed it to refer back to the original license. Hope that's enough. My main goal is to not supercede credit when this is largely someone else's work, and I only made very minimal changes to it. |
README.md
Outdated
| - block_annihilated.ogg, drill_dig.ogg: "[SFX Hit] deep kick boom" by waveplaySFX -- https://freesound.org/s/231349/ -- License: Attribution 4.0 | ||
| - block_annihilated.ogg: "[SFX Hit] deep kick boom" by waveplaySFX -- https://freesound.org/s/231349/ -- License: Attribution 4.0 | ||
| - pop fix for block_annihilated.ogg by AbbyRead (derivative rights released; refer to above license to credit the original creator if used) | ||
| - heavily edited for drill_dig.ogg by TheEt1234: all rights reserved derivative work (default state of it, as license was unspecified at the time) |
There was a problem hiding this comment.
it would still be good to specify that it was based on that though (i only vaguely remember doing it though, i wish i was more aware of licensing back then)
sorry for being annoying with licensing i just dont want to mess it up
There was a problem hiding this comment.
Nah, it's cool. I'm new here but I've had years of needless worry over licensing issues that at this point I just state intentions more often than copy/pasting licenses. Copyright law is so freaking terse, but stuff defaults to full copyright (outside of any fine print agreement made prior on things like GitHub). The copyright owner can always make things less restricted, so I was erriing on the side of caution when I put in that statement.
To clear up what I understand about it though, for things like using a song in a movie for example, the movie could be seen as a derivative work of the song, but the movie has its own license. The song creator can't just sell the movie, and even if the creator makes the movie-specific content public domain later, they would have to still observe the song's copyright (and likely strip it out for ease of use by the public). An example is the DVD release of the show "Daria" which was originally aired on MTV and had popular music from the time, but they had to swap that stuff out because they would be doing a separate license agreement about it. You'll also see re-releases of popular games like GTA3, Vice City, and San Andreas have songs stripped out of their Greatest Hits rereleases because the license wasn't in perpetuity.
TLDR: Copyright law is hell, but I don't personally think we have anything to worry about aside from upsetting someone by not giving proper credit. There's no money to be gained from litigation here, so we're not a target for legal action, only slightly potentially a target for internet ire if we don't at least try to say where we got things from if not made ourselves wholecloth. I'm really glad you guys care though because it's a really good habit to observe best practices wherever possible.
There was a problem hiding this comment.
Nah, it's cool. I'm new here but I've had years of needless worry over licensing issues that at this point
Yikes, sorry to add to that
There's no money to be gained from litigation here, so we're not a target for legal action, only slightly potentially a target for internet ire if we don't at least try to say where we got things from if not made ourselves wholecloth. I'm really glad you guys care though because it's a really good habit to observe best practices wherever possible.
ContentDB requires us to try to have correct licensing, as far as i am aware
I wasn't aware about licensing stuff some years before (when i contributed the most to sbz), i will try to fix up most of the mistakes i made during that time and sbz shouldn't release until the mistakes i am aware of are fixed
and it is the good/moral thing to do, yes
There was a problem hiding this comment.
YouTube copyright claims cut my teeth on the stuff. Then working for a video streaming startup called Machinima that has since went under. Had to deal with a lot of directors not giving a crap where they took from, but since money got involved it got more serious. They still got away with a lot due to parody (fair enough) and fair use, which is a lot more nebulous. But the main thing is I just had the worry sort of beaten out of me by the clusterfudge of what actually slides and what really shouldn't. You guys on here are doing a lot more work (and credit to that, for real) than what's entirely necessary.
I know you don't know me, and me saying you don't gotta worry doesn't necessarily mean much when I don't have any stake in this project aside from thinking the game is really cool and wanting to help... but I assure you, this stuff isn't as scary as it sounds. The worst thing that can happen is that you get a heads up you did something wrong, and you just politely fix it with a thanks to the person who pointed it out. But I will defer to whatever you like. I really will. This ain't my baby, and I don't want to step on toes. I think it's really cool though and will help in whatever way I'm able.
There was a problem hiding this comment.
You guys on here are doing a lot more work (and credit to that, for real) than what's entirely necessary.
Well, it would be best to make it very clear how you can use SBZ media (unsure if "CC-BY-SA 4.0 Zander and contributors" is a good way) and its how the authors wish their work was distributed
There was a problem hiding this comment.
You guys on here are doing a lot more work (and credit to that, for real) than what's entirely necessary.
Well, it would be best to make it very clear how you can use SBZ media (unsure if "CC-BY-SA 4.0 Zander and contributors" is a good way) and its how the authors wish their work was distributed
|
To be honest, I'm pretty sure I'm the one being annoying here. I think it's probably a narcisistic tendency on my part to be somewhat stubborn with the way I choose to go about things. If you want to just put the same license on it or even not credit my contributions here, whatever's easier, I'm fine with that. My statements on the thread amount to actionable proof of permission, so there's no worry of doing whatever you like with my contributions. On my own stuff I always just use 0BSD since from what I hear that's the most legally solid statement of permission closest to public domain because of the legal precidence set by the more restrictive BSD licenses being litigated a bunch. Zero-Clause BSD ftw because I'd rather just see my stuff get used and be helpful. I don't care about credit if people enjoy the stuff I create or improvements I try to make on existing things. I respect others that do. It's just not my impetus for creating things. |
README.md
Outdated
|
|
||
| - hard_drive_shut_down_01.wav by Noisehag -- https://freesound.org/s/110552/ -- License: Creative Commons 0 | ||
| - block_annihilated.ogg: "[SFX Hit] deep kick boom" by waveplaySFX -- https://freesound.org/s/231349/ -- License: Attribution 4.0 | ||
| - block_annihilated.ogg, drill_dig.ogg: "[SFX Hit] deep kick boom" by waveplaySFX -- https://freesound.org/s/231349/ -- License: Attribution 4.0 |
There was a problem hiding this comment.
i am really really really sorry for being nitpicky but this would imply that waveplaySFX made drill_dig.ogg, or that it wasn't heavily modified, i think
which isn't true
i would suggest doing it in the style like
- drill_dig.ogg: Heavily modified block_annihilated.ogg, block_annihilated.ogg was created by waveplaySFX, license of drill_dig.ogg: CC-BY, by TheEt1234
I don't know if that's correct, i am not a lawyer
There was a problem hiding this comment.
My suggestion.
- block_annihilated.ogg. CC-BY 4.0 (c) waveplaySFX, TheEt1234, AbbyRead. Created from modifying "[SFX Hit] deep kick boom" CC-BY 4.0 (c) waveplaySFX <https://freesound.org/s/231349/>.
- drill_dig.ogg. CC-BY 4.0 (c) waveplaySFX, TheEt1234, AbbyRead. Created from modifying "[SFX Hit] deep kick boom" CC-BY 4.0 (c) waveplaySFX <https://freesound.org/s/231349/>.There was a problem hiding this comment.
Done and submitted. Thanks, corpserot!
|
wait it should be CC-BY 4.0 because not specifying the version is awkward... oh |
|
ok, looks good to me, @ChefZander you can merge |
3 participants
The commits each have more detailed descriptions of what I changed, but mostly it's just fixing the popping and clipping issues present. I wasn't able to make a direct fix of the TNT explosion because that thing has just a heavily compromized original recording. Not the right kind of microphone probably or too much gain on recording. But every attempt to fix that one had compromizes that I'm not entirely sure you guys will prefer, so I made it an alt version instead of a direct replacement. It's up to you. I don't consider this authoritatively my opinion of the best sound effects; I just wanted to improve what's here a bit if I can.