-
Notifications
You must be signed in to change notification settings - Fork 21
Sound Effect Fixes #207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ChefZander
merged 11 commits into
ChefZander:master
from
AbbyRead:resource-modifications
Jan 24, 2026
+4
−2
Merged
Sound Effect Fixes #207
Changes from 9 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
704bb06
Update block_annihilated.ogg
AbbyRead ecb8605
Fix popping in drill_dig.ogg
AbbyRead a131a85
Remix tnt explosion sound
AbbyRead 1fa80de
Remove delay in machine_open.ogg
AbbyRead de6cd2e
Remove tnt alt sound effect
AbbyRead 6e85751
Include info in the readme about changes made and about drill_dig.ogg
AbbyRead 78522c8
Make intentions clearer with regard to credit and license
AbbyRead 3e07143
Return to nature
AbbyRead 9974684
Fix my making things slightly worse regarding clarity of source
AbbyRead 53dd35c
Copy/paste intended credit and license from TheEt1234
AbbyRead b83e350
Take
AbbyRead File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Binary file not shown.
Binary file not shown.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i am really really really sorry for being nitpicky but this would imply that waveplaySFX made drill_dig.ogg, or that it wasn't heavily modified, i think
which isn't true
i would suggest doing it in the style like
I don't know if that's correct, i am not a lawyer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure thing.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My suggestion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, do that one ^ (Thanks @corpserot)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done and submitted. Thanks, corpserot!