Script to migrate .nemo checkpoints that used torchaudio preprocessor#15437
Script to migrate .nemo checkpoints that used torchaudio preprocessor#15437
Conversation
Signed-off-by: Piotr Żelasko <petezor@gmail.com>
|
Should we define a load_state_dict override inside of the AudioPreprocessor class that does this automatically if preprocessor.use_torchaudio=True or would you prefer to keep it as a separate helper script? |
… during tarfile extraction Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: Piotr Żelasko <petezor@gmail.com>
Signed-off-by: pzelasko <pzelasko@users.noreply.github.com>
@blisc I want to minimize the core code complexity, this use-case seems niche enough that a migration script should be sufficient. I committed bot's suggested fix. |
|
@MahmoudAshraf97 I see the approval but can you confirm that tested it on your checkpoints and it works OK? |
|
fortunately you didn't take my approval for granted 😄 , it is not working due to a shape mismatch, I'll work on a solution and suggest it in a review |
MahmoudAshraf97
left a comment
There was a problem hiding this comment.
it's hardcoded but I don't think we need a generalized solution for this
Co-authored-by: Mahmoud Ashraf <hassouna97.ma@gmail.com> Signed-off-by: Piotr Żelasko <petezor@gmail.com>
|
Applied your fix - can you confirm that it works correctly in this version @MahmoudAshraf97 ? |
|
it does, the converted model loads and infers successfully |
Important
The
Update branchbutton must only be pressed in very rare occassions.An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.
What does this PR do ?
Script to migrate .nemo checkpoints that used torchaudio preprocessor
Collection: asr
Changelog
Usage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information