[rocprofiler-compute] Update test_metric_validation.py to handle MI325X #2866
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the rocprofiler-compute metric validation test to support MI325X (MI300-series) by allowing multiple acceptable expected metric values.
Changes:
- Replaced single
expected_valueentries withexpected_valueslists for all validated GPUs. - Updated the validation logic to pass when the measured metric matches any expected value within the existing 5% tolerance.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
feizheng10
approved these changes
Jan 26, 2026
xuchen-amd
approved these changes
Jan 26, 2026
jbonnell-amd
approved these changes
Jan 26, 2026
Contributor
Author
|
/AzurePipelines run rocm-ci-caller |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Update test_metric_validation.py to handle MI325X
Technical Details
MI325X is a memory focused refresh of MI300X in MI 300 series lineup which uses improved HBM3E instead of HBM3.
Hence, update metrics validation test case to validate multiple possible metric values.
JIRA ID
Test Plan
Test Result
Submission Checklist