Skip to content

[rocprofiler-compute] Update test_metric_validation.py to handle MI325X #2866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vedithal-amd merged 1 commit into from
Jan 27, 2026
Merged

[rocprofiler-compute] Update test_metric_validation.py to handle MI325X #2866

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 18 additions & 10 deletions projects/rocprofiler-compute/tests/test_metric_validation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
"metric_id": "4.1.8",
"csv_file": "4.1_Roofline_Performance_Rates.csv",
"column": "Value",
"expected_value": 1044.48,
"expected_values": [1044.48],
},
],
"MI200": [
Expand All @@ -51,7 +51,7 @@
"metric_id": "4.1.8",
"csv_file": "4.1_Roofline_Performance_Rates.csv",
"column": "Value",
"expected_value": 1389.17,
"expected_values": [1389.17],
},
],
"MI300": [
Expand All @@ -60,7 +60,11 @@
"metric_id": "4.1.9",
"csv_file": "4.1_Roofline_Performance_Rates.csv",
"column": "Value",
"expected_value": 3910.62,
# MI 300 series contains MI325X GPU which
# uses improved HBM3E instead of HBM3 used in
# MI300X GPU. Hence, multiple expected values
# to cover both cases.
"expected_values": [3910.62, 4287.31],
},
],
"MI350": [
Expand All @@ -69,7 +73,7 @@
"metric_id": "4.1.10",
"csv_file": "4.1_Roofline_Performance_Rates.csv",
"column": "Value",
"expected_value": 5690.42,
"expected_values": [5690.42],
},
],
# Ignore warmup dispatch
Expand Down Expand Up @@ -131,13 +135,17 @@ def test_validate_metrics(
actual = pd.read_csv(f"{analysis_workload_dir}/{metric['csv_file']}")[
metric["column"]
].values[0]
expected = metric["expected_value"]
# 5% tolerance in checking
assert abs(actual - expected) / expected <= 0.05, (
expected_values = metric["expected_values"]
# 5% tolerance in checking - assert if actual matches any expected value
matches = [
abs(actual - expected) / expected <= 0.05
for expected in expected_values
]
diffs = [(abs(actual - exp) / exp * 100) for exp in expected_values]
assert any(matches), (
f"{metric['name']} ({metric['metric_id']}): "
f"actual={actual}, expected={expected}, "
f"diff={(abs(actual - expected) / expected * 100):.2f}% "
f"(tolerance: 5%)"
f"actual={actual}, expected_values={expected_values}, "
f"diffs={diffs} (tolerance: 5%)"
)
finally:
test_utils.clean_output_dir(config["cleanup"], analysis_workload_dir)
Expand Down
Loading