test: fix TestHandshakeReplayXXX tests w/ count >= 2#5116
Open
aeddi wants to merge 3 commits intognolang:masterfrom
Open
test: fix TestHandshakeReplayXXX tests w/ count >= 2#5116aeddi wants to merge 3 commits intognolang:masterfrom
aeddi wants to merge 3 commits intognolang:masterfrom
Conversation
Collaborator
🛠 PR Checks SummaryAll Automated Checks passed. ✅ Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🟢 Maintainers must be able to edit this pull request (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
jefft0
approved these changes
Feb 3, 2026
Contributor
jefft0
left a comment
There was a problem hiding this comment.
This works for me with -count=2 . I can't comment on whether the fix is correct.
sw360cab
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5115
I'm not sure this fix is good, even if it does solve the count issue.
These tests could use a proper refactor and some comments to understand how they work.
It's complicated to understand the flow and the original intention in this area with the
configglobal var, theconfiglocal var (parameter), thesim.Config, and the role oftestConfigbeyond just removing its root.