Skip to content

test: fix TestHandshakeReplayXXX tests w/ count >= 2#5116

Open
aeddi wants to merge 3 commits intognolang:masterfrom
aeddi:fix-replay-test
Open

test: fix TestHandshakeReplayXXX tests w/ count >= 2#5116
aeddi wants to merge 3 commits intognolang:masterfrom
aeddi:fix-replay-test

Conversation

@aeddi
Copy link
Contributor

@aeddi aeddi commented Feb 3, 2026

Fixes #5115

I'm not sure this fix is good, even if it does solve the count issue.
These tests could use a proper refactor and some comments to understand how they work.

It's complicated to understand the flow and the original intention in this area with the config global var, the config local var (parameter), the sim.Config, and the role of testConfig beyond just removing its root.

@Gno2D2
Copy link
Collaborator

Gno2D2 commented Feb 3, 2026

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 The pull request was created from a fork (head branch repo: aeddi/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

@aeddi aeddi requested a review from a team February 3, 2026 15:49
@codecov
Copy link

codecov bot commented Feb 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copy link
Contributor

@jefft0 jefft0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for me with -count=2 . I can't comment on whether the fix is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📦 🌐 tendermint v2 Issues or PRs tm2 related

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

go test with -count=2 fails on some tests

4 participants