Skip to content

test: fix TestHandshakeReplayXXX tests w/ count >= 2 #5116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aeddi wants to merge 3 commits into
base: master
Choose a base branch
from
+11 −9
Open

test: fix TestHandshakeReplayXXX tests w/ count >= 2 #5116

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dd9c926
test: fix TestHandshakeReplayXXX tests w/ count >= 2
aeddi Feb 3, 2026
66d7b98
Merge branch 'master' into fix-replay-test
aeddi Feb 3, 2026
a9ae584
test: remove unused config param
aeddi Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions tm2/pkg/bft/consensus/replay_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -649,7 +649,7 @@
}

// Make some blocks. Start a fresh app and apply nBlocks blocks. Then restart the app and sync it up with the remaining blocks
func testHandshakeReplay(t *testing.T, config *cfg.Config, nBlocks int, mode uint, sim *testSim) {

Check failure on line 652 in tm2/pkg/bft/consensus/replay_test.go

View workflow job for this annotation

GitHub Actions / Run TM2 suite / Go Lint / lint 

SA4009: argument config is overwritten before first use (staticcheck)
t.Helper()

var (
Expand All @@ -668,7 +668,7 @@
stateDB = memdb.NewMemDB()
defer stateDB.Close()
genesisState = sim.GenesisState
config = sim.Config

Check failure on line 671 in tm2/pkg/bft/consensus/replay_test.go

View workflow job for this annotation

GitHub Actions / Run TM2 suite / Go Lint / lint 

SA4009(related information): assignment to config (staticcheck)
chain = sim.Chain
commits = sim.Commits
store = newMockBlockStore(config, genesisState.ConsensusParams)
Expand All @@ -676,6 +676,7 @@
} else { // test single node
testConfig, gf := ResetConfig(fmt.Sprintf("%s_%v_s", t.Name(), mode))
defer os.RemoveAll(testConfig.RootDir)
config = testConfig
walBody, err := WALWithNBlocks(t, numBlocks)
require.NoError(t, err)
walFile := tempWALWithData(walBody)
Expand Down
Loading