Skip to content

Conversation

@GrunyD
Copy link

@GrunyD GrunyD commented Nov 8, 2025

The Checkbox next to a folder now selects the folder. It doesn't select all its contents. There is no button to automatically select all contents of the folder.
Folder doesn't open when selected.
There is no '.' file in folder.
There is a feature allowing you to quickly select a large amount of files within the same folder, if you hold shift. It also allows you to deselect files in the same way.
Python raises ValueError if file_count = 'single', but value is a iterable of multiple files.

Description

Please include a concise summary, in clear English, of the changes in this pull request. If it closes an issue, please mention it here.

Closes: #11390

AI Disclosure

We encourage the use of AI tooling in creating PRs, but the any non-trivial use of AI needs be disclosed. E.g. if you used Claude to write a first draft, you should mention that. Trivial tab-completion doesn't need to be disclosed. You should self-review all PRs, especially if they were generated with AI.

  • I used AI to... [fill here]
  • I did not use AI

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Testing and Formatting Your Code

  1. PRs will only be merged if tests pass on CI. We recommend at least running the backend tests locally, please set up your Gradio environment locally and run the backed tests: bash scripts/run_backend_tests.sh

  2. Please run these bash scripts to automatically format your code: bash scripts/format_backend.sh, and (if you made any changes to non-Python files) bash scripts/format_frontend.sh

GrunyD and others added 2 commits November 8, 2025 16:12
The Checkbox next to a folder now selects the folder. It doesn't select
all its contents. There is no button to automatically select all contents
of the folder.
Folder doesn't open when selected.
There is no '.' file in folder.
There is a feature allowing you to quickly select a large amount of files
within the same folder, if you hold shift. It also allows you to deselect
files in the same way.
@freddyaboulton
Copy link
Collaborator

HI @GrunyD ! Thanks for the PR. The change in checkbox behavior is a breaking change so this PR cannot be merged as is. In your original issue you mentioned :

Also another problem arises as mentioned at the end of the #9835. If you let people to only see folders, it is not possible to select them.

That would be a welcome bug fix in this PR!

@GrunyD
Copy link
Author

GrunyD commented Jan 7, 2026

I am not sure I follow. It is a breaking change, but some different behaviour would be a welcome bug fix? Could you be more specific, please? Can I somehow change it so it still behaves like I want, but isn't breaking change? What exactly is the problem?

@freddyaboulton
Copy link
Collaborator

The Checkbox next to a folder now selects the folder. It doesn't select all its contents.

This is a breaking change. We should not change the behavior of the checkbox in this way. However, you mentioned that if the glob pattern allows for only directories, it is not possible to to select an individual directory. Let's fix that in this pr.

You mentioned that you think using a . to indicate the directory is confusing. Maybe we can include the directory name? We can discuss in a separate PR.

@freddyaboulton
Copy link
Collaborator

Going to close for lack of follow up but we welcome a contribution incorporating the comment above!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Selecting a folder in FileExplorer

3 participants