Feature: Croesus Profit Overlay

[Fazfoxy]

What

Neu is slowly breaking (doesn't count chest cost for instance chest profit & hasn't worked on attribute shards, ever but now this matters ever since Foraging update) & since we have Instance Chest Profit it makes some sense for us to inherit this part of NEU's equivalent features between versions since we already had half of it

Images

Changelog New Features

• Croesus Profit Overlay and Highlight most profitable chest. - Fazfoxy

[github-actions]

3 Detekt Failures

Rules flagged (2): UnsafeCallOnNullableType, VarCouldBeVal

• InstanceChestProfit.kt#L253 UnsafeCallOnNullableType: Calling !! on a nullable type will throw a NullPointerException at runtime in case the value is null. It should be avoided.
• InstanceChestProfit.kt#L222 VarCouldBeVal: Variable 'chestList' could be val.
• InstanceChestProfit.kt#L223 VarCouldBeVal: Variable 'chestTipsRenderables' could be val.

[github-actions]

13 Detekt Failures

Rule violations

• InstanceChestProfit.kt#L238 Indentation: Unexpected indentation (16) (should be 12)
• InstanceChestProfit.kt#L239 Indentation: Unexpected indentation (16) (should be 12)
• InstanceChestProfit.kt#L240 Indentation: Unexpected indentation (20) (should be 16)
• InstanceChestProfit.kt#L241 Indentation: Unexpected indentation (16) (should be 12)
• InstanceChestProfit.kt#L242 Indentation: Unexpected indentation (16) (should be 12)
• InstanceChestProfit.kt#L243 Indentation: Unexpected indentation (20) (should be 16)
• InstanceChestProfit.kt#L244 Indentation: Unexpected indentation (20) (should be 16)
• InstanceChestProfit.kt#L245 Indentation: Unexpected indentation (16) (should be 12)
• InstanceChestProfit.kt#L246 Indentation: Unexpected indentation (16) (should be 12)
• InstanceChestProfit.kt#L247 Indentation: Unexpected indentation (20) (should be 16)
• InstanceChestProfit.kt#L248 Indentation: Unexpected indentation (20) (should be 16)
• InstanceChestProfit.kt#L249 Indentation: Unexpected indentation (20) (should be 16)
• InstanceChestProfit.kt#L250 Indentation: Unexpected indentation (16) (should be 12)

[github-actions]

1 Detekt Failure

• InstanceChestProfit.kt#L135 RepoPatternRegexTestMissing: Repo pattern bookColorFixer must have a regex test.

[hannibal002]

not tested in game, just a first review

[github-actions]

1 Detekt Failure

• InstanceChestProfit.kt#L160 VarCouldBeVal: Variable 'slotsWithFavourites' could be val.

[github-actions]

7 Detekt Failures

Rules flagged (2): SpacingAroundCurly, Indentation

Rule violations

• InstanceChestProfit.kt#L427 SpacingAroundCurly: Missing spacing before "{"
• InstanceChestProfit.kt#L427 Indentation: Unexpected indentation (8) (should be 12)
• InstanceChestProfit.kt#L428 Indentation: Unexpected indentation (12) (should be 16)
• InstanceChestProfit.kt#L429 Indentation: Unexpected indentation (16) (should be 20)
• InstanceChestProfit.kt#L430 Indentation: Unexpected indentation (16) (should be 20)
• InstanceChestProfit.kt#L431 Indentation: Unexpected indentation (12) (should be 16)
• InstanceChestProfit.kt#L432 Indentation: Unexpected indentation (8) (should be 12)

[github-actions]

1 Detekt Failure

• InstanceChestProfitConfig.kt#L52 MaxLineLength: Line detected, which is longer than the defined maximum line length in the code style.

[Fazfoxy]

Favourite example screenshot (favouriting system is a bit, meh, but I can't think of a better way under Moul rn)

[NopoTheGamer]

if multiple chests contain a favourite item only 1 star is shown

also the actual chest profit display has no indication of favourited item
should show the star in the display and on the actual item

[github-actions]

1 Detekt Failure

• TextCompat.kt#L408 MaxLineLength: Line detected, which is longer than the defined maximum line length in the code style.