-
-
Notifications
You must be signed in to change notification settings - Fork 297
Feature: Croesus Profit Overlay #4857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
NopoTheGamer
merged 103 commits into
hannibal002:beta
from
Fazfoxy:Croesus-Profit-Overlay
Jan 29, 2026
Merged
Changes from 19 commits
Commits
Show all changes
103 commits
Select commit
Hold shift + click to select a range
8234ab4
I don't understnad
Fazfoxy f26f86b
I somehow understand what is broken less now, whar
Fazfoxy 235d6fa
Enchanted Book price resolution makes me feel like I am clueless as hell
Fazfoxy 3f60c8d
actually functions thanks to nopo
Fazfoxy 489b08a
actual Attribute Detection (and it works!)
Fazfoxy cc62ac9
Highlight, Book Shenanigans & Ignore already Opened Chests & Nicer lo…
Fazfoxy 0fa75ff
Merge branch 'hannibal002:beta' into Croesus-Profit-Overlay
Fazfoxy 43c1ea6
slightly nicer tooltip on Chests
Fazfoxy 67069a4
detekt and sillyness
Fazfoxy a1846ea
non nullable internalName
Fazfoxy ded0e89
detekt
Fazfoxy afad11c
currentLoreLine --> loreLine (why did I make it current that's stupid)
Fazfoxy 51bb08f
Book resolution MUCH Cleaner
Fazfoxy e4801a9
formatting
Fazfoxy bb55ce6
detekt
Fazfoxy 9c5e715
Useless Reset removal.
Fazfoxy d45d291
Merge branch 'hannibal002:beta' into Croesus-Profit-Overlay
Fazfoxy a33c6b7
Merge branch 'refs/heads/beta' into fork/Fazfoxy/Croesus-Profit-Overlay
hannibal002 5a786ac
cleanup
hannibal002 9aad050
I can't actually think of a way to do this that isn't reliant on rend…
Fazfoxy eaa3321
the mega commit of review changes (oops)
Fazfoxy ecbcd3c
Lies now
Fazfoxy db675b2
detekt less hating of me?
Fazfoxy 79126dd
Books decided to give up on working, I'm not even sure how or why thi…
Fazfoxy 920d145
lets not use renderable.table to create lists actually
Fazfoxy 49de033
Config name for new feature felt silly
Fazfoxy 96c09b7
maybe make config link work
Fazfoxy 2dc3ae6
using more strings
hannibal002 a606718
no longer throw Missing Item Errors at the user
Fazfoxy 951fb39
This should be a good name for the future if someone inexplicably add…
Fazfoxy 27a5e40
Merge branch 'hannibal002:beta' into Croesus-Profit-Overlay
Fazfoxy 0f2cded
TODO & Explainer comments for the next person to touch this feature.
Fazfoxy bfa33e0
more proper explanation & direct links for an exact point at which it…
Fazfoxy d309956
I don't understnad
Fazfoxy 45e7660
I somehow understand what is broken less now, whar
Fazfoxy f0153af
Enchanted Book price resolution makes me feel like I am clueless as hell
Fazfoxy d888cec
actually functions thanks to nopo
Fazfoxy 9082c0e
actual Attribute Detection (and it works!)
Fazfoxy c646fda
Highlight, Book Shenanigans & Ignore already Opened Chests & Nicer lo…
Fazfoxy a8448b0
slightly nicer tooltip on Chests
Fazfoxy fb92079
detekt and sillyness
Fazfoxy 67e5058
non nullable internalName
Fazfoxy f2a0a5a
detekt
Fazfoxy 692ca06
currentLoreLine --> loreLine (why did I make it current that's stupid)
Fazfoxy 44289dc
Book resolution MUCH Cleaner
Fazfoxy 2491885
formatting
Fazfoxy 3e59818
detekt
Fazfoxy 9ef813b
Useless Reset removal.
Fazfoxy aec77c0
merge conflicts
hannibal002 4b5b8c1
I can't actually think of a way to do this that isn't reliant on rend…
Fazfoxy f9ee2fd
the mega commit of review changes (oops)
Fazfoxy dadbc10
Lies now
Fazfoxy 406b9f0
detekt less hating of me?
Fazfoxy f976292
merge conflicts
Fazfoxy 421a94e
lets not use renderable.table to create lists actually
Fazfoxy 44a4563
Config name for new feature felt silly
Fazfoxy 7f22ab1
maybe make config link work
Fazfoxy 0fce0b2
using more strings
hannibal002 3690c7a
no longer throw Missing Item Errors at the user
Fazfoxy cdecdc1
This should be a good name for the future if someone inexplicably add…
Fazfoxy 9a01904
merge conflicts
Fazfoxy 25bcacc
Merge remote-tracking branch 'origin/Croesus-Profit-Overlay' into Cro…
Fazfoxy 0e25aca
Merge branch 'hannibal002:beta' into Croesus-Profit-Overlay
Fazfoxy 6ba47cb
Merge branch 'beta' into Croesus-Profit-Overlay
Fazfoxy 8e63fea
Merge remote-tracking branch 'origin/Croesus-Profit-Overlay' into Cro…
Fazfoxy 962c539
Kuudra chest fix
Fazfoxy 1685e3d
I'm not even sure what's going on here because I'm pretty sure Blox i…
Fazfoxy b69c0b6
Dungeon Chest Key Fix
Fazfoxy d91d987
Merge branch 'hannibal002:beta' into Croesus-Profit-Overlay
Fazfoxy 7f94081
Merge branch 'hannibal002:beta' into Croesus-Profit-Overlay
Fazfoxy d64052c
Merge branch 'hannibal002:beta' into Croesus-Profit-Overlay
Fazfoxy 35c334d
Fix Book resolving in Chests on 1.21 due to falty pattern with starti…
Fazfoxy f7e4caa
Merge branch 'beta' into Croesus-Profit-Overlay
Fazfoxy 8fb64f1
actually works
Fazfoxy 09bbc0b
Merge branch 'hannibal002:beta' into Croesus-Profit-Overlay
Fazfoxy ecde674
pain
Fazfoxy f5eecbd
Merge branch 'hannibal002:beta' into Croesus-Profit-Overlay
Fazfoxy 001ac93
Merge branch 'hannibal002:beta' into Croesus-Profit-Overlay
Fazfoxy 3357e6c
Merge branch 'hannibal002:beta' into Croesus-Profit-Overlay
Fazfoxy 0298c91
fixed Multiple Copies of Chests & added runnable
Fazfoxy 954cadf
Detekt?
Fazfoxy 01c7139
Wood Chest Fix from 2 weeks ago error
Fazfoxy 857277d
Merge remote-tracking branch 'origin/beta' into Croesus-Profit-Overlay
Fazfoxy 93a47d4
Renderable Vertical & Merge Conflicts
Fazfoxy 1593eea
Should be entirely Paritied with before.
Fazfoxy fa536ef
non functional Favouriting System
Fazfoxy 90fbfbb
actually Functional Favouriting !!!
Fazfoxy 5668d76
detekt stuff
Fazfoxy 0a1bded
more detekt stuff
Fazfoxy 57f2ad1
final detekt stuff for now
Fazfoxy 77c3be2
Should Probably Not break the other feature.
Fazfoxy 8f7fcdf
fixed other chest feature (oops) and did the Todo & marked favourites…
Fazfoxy fff0f55
Detekt Surely
Fazfoxy d203d50
Formatting & wording
Fazfoxy 5918aa1
allow favouriting outside of Chests & Detekt, again
Fazfoxy e960972
remove the British, but detekt doesn't pick this one up.
Fazfoxy b3ba607
Merge branch 'hannibal002:beta' into Croesus-Profit-Overlay
Fazfoxy 3b156ed
Merge branch 'hannibal002:beta' into Croesus-Profit-Overlay
Fazfoxy 24642ee
Favourites in Instance Chest GUI & Favourites work on Wood Chest
Fazfoxy f9b155e
Merge branch 'hannibal002:beta' into Croesus-Profit-Overlay
Fazfoxy 6f21a83
Merge branch 'hannibal002:beta' into Croesus-Profit-Overlay
Fazfoxy 2acb400
Merge branch 'hannibal002:beta' into Croesus-Profit-Overlay
Fazfoxy fa51f12
Merge branch 'hannibal002:beta' into Croesus-Profit-Overlay
Fazfoxy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.