Fix _bulk_create for ManyToManyField with custom through models (#477)
#570
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the change
I figured that
bulk_createwas using incorrect properties (the related model's name/related_name) for getting FK names.Replaced
field.remote_field.nameandfield.related_model._meta.model_namewith Django'sfield.m2m_field_name()andfield.m2m_reverse_field_name()(ref) which return the correct FK field names for both auto-created and custom through models.PR Checklist
Summary by CodeRabbit
Bug Fixes
Tests
✏️ Tip: You can customize this high-level summary in your review settings.