Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
### Added

### Changed
- Fix `_bulk_create` for ManyToManyField using custom `through` models ([#477](https://github.com/model-bakers/model_bakery/issues/477))
- [dev] Clean up stale TODO and fix signal handler leak in m2m test

### Removed
Expand Down
4 changes: 2 additions & 2 deletions model_bakery/baker.py
Original file line number Diff line number Diff line change
Expand Up @@ -940,8 +940,8 @@ def bulk_create(baker: Baker[M], quantity: int, **kwargs) -> list[M]:
[
through_model(
**{
field.remote_field.name: entry,
field.related_model._meta.model_name: obj,
field.m2m_field_name(): entry,
field.m2m_reverse_field_name(): obj,
}
)
for obj in kwargs[field.name]
Expand Down
25 changes: 25 additions & 0 deletions tests/test_baker.py
Original file line number Diff line number Diff line change
Expand Up @@ -458,6 +458,31 @@ def test_regression_many_to_many_field_is_accepted_as_kwargs(self):
assert store.customers.count() == 3
assert models.Person.objects.count() == 6

@pytest.mark.django_db
def test_bulk_create_with_m2m(self):
"""Regression test for issue #477."""
employees = baker.make(models.Person, _quantity=3)
stores = baker.make(
models.Store, employees=employees, _quantity=2, _bulk_create=True
)

assert models.Store.objects.count() == 2
assert stores[0].employees.count() == 3
assert stores[1].employees.count() == 3

@pytest.mark.django_db
def test_bulk_create_with_m2m_through_model(self):
"""Regression test for issue #477 - custom through model."""
students = baker.make(models.Person, _quantity=3)
schools = baker.make(
models.School, students=students, _quantity=2, _bulk_create=True
)

assert models.School.objects.count() == 2
assert schools[0].students.count() == 3
assert schools[1].students.count() == 3
assert models.SchoolEnrollment.objects.count() == 6

@pytest.mark.django_db
def test_create_many_to_many_with_iter(self):
students = baker.make(models.Person, _quantity=3)
Expand Down