refactor(oxcaml): split parameterised rules #13413
Merged
+238
−230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
art-w
commented
Jan 21, 2026
| | Simple of instance | ||
| | Wrapped of Loc.t * Module_name.t * instance list | ||
|
|
||
| type t = instances list |
Collaborator
Author
There was a problem hiding this comment.
This new module is identical to the code deleted from parameterised_rules, except for the introduction of this new type t to make the signatures shorter.
Signed-off-by: Arthur Wendling <arthur@tarides.com>
art-w
force-pushed
the
refactor-parameterised-instances
branch
from
540d22b to
56dca68
Compare
rgrinberg
approved these changes
Jan 21, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple split of the
parameterised_rules.mlfile in two files (one for the rules and one for printing the instances in the alias file), to prepare for the jsoo rules for OxCaml parameterised libs: Otherwise, there'll be a cycle whenParameterised_rulesstarts callingJsoo_rules -> Compilation_context -> Parameterised_rules. With this PR, the last module becomesParameterised_instanceswhich breaks the cycle.