feat(oxcaml): jsoo support for parameterised libs #13414
Draft
+221
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
art-w
force-pushed
the
parameterised-jsoo-incr
branch
from
963b052 to
461453a
Compare
Signed-off-by: Arthur Wendling <arthur@tarides.com>
art-w
force-pushed
the
parameterised-jsoo-incr
branch
2 times, most recently
from
33fe26a to
20688b6
Compare
Signed-off-by: Arthur Wendling <arthur@tarides.com>
art-w
force-pushed
the
parameterised-jsoo-incr
branch
from
20688b6 to
c9be07b
Compare
art-w
commented
Jan 22, 2026
| ocaml-compiler: ocaml-variants.5.2.0+ox | ||
| opam-repositories: | | ||
| oxcaml: "git+https://github.com/oxcaml/opam-repository.git" | ||
| oxcaml: "git+https://github.com/art-w/oxcaml-opam-repository.git#jsoo-oxcaml" |
Collaborator
Author
There was a problem hiding this comment.
TODO @art-w: revert this manual pin on the patched jsoo once oxcaml/opam-repository#31 or equivalent is merged, it's only there to enable review with a green CI
Alizter
reviewed
Jan 23, 2026
| Action_builder.of_memo @@ Version.jsoo_version jsoo | ||
| in | ||
| let libs = | ||
| List.map libs ~f:(Lib.Parameterised.for_instance ~build_dir ~ext_lib:"unused") |
Collaborator
There was a problem hiding this comment.
Could you explain what is going on here?
Collaborator
Author
There was a problem hiding this comment.
The Lib.Parameterised.for_instance updates the library to point to its instantiated version in the build_dir (in case it has arguments, otherwise it does nothing). The native archive uses ext_lib as the extension, but for jsoo it isn't used as we only need the bytecode one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better support than #12762 since @hhugo fixed the
js_of_ocamlsupport for OxCaml parameterised libs to enable separate compilation!(Builds on top of a small refactoring #13413 , only the last commit is relevant... Although the code works, I'm marking this PR as a draft since the CI is expected to fail until the oxcaml opam-repo ships jsoo with the fix)