fix(1560): add more explicit errors on get cv #1787
Merged
+16
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
kind/bugfix
piotrjanik
reviewed
Jan 21, 2026
cmds/ocm/commands/ocmcmds/common/handlers/comphdlr/typehandler.go
Outdated
Show resolved
Hide resolved
matthiasbruns
force-pushed
the
fix/1560_confusing_error_logging
branch
from
981a0f3 to
377cf76
Compare
piotrjanik
approved these changes
Jan 23, 2026
jakobmoellerdev
approved these changes
Jan 23, 2026
Member
|
please sign your commits |
Contributor
Author
They are - at least I checked the commit history, all except the ones here from GitHubs 'Update Branch' button |
matthiasbruns
force-pushed
the
fix/1560_confusing_error_logging
branch
from
d95f0b5 to
2593800
Compare
…model#398) * Bump github.com/cloudflare/circl from 1.1.0 to 1.3.3 Bumps [github.com/cloudflare/circl](https://github.com/cloudflare/circl) from 1.1.0 to 1.3.3. - [Release notes](https://github.com/cloudflare/circl/releases) - [Commits](cloudflare/circl@v1.1.0...v1.3.3) --- updated-dependencies: - dependency-name: github.com/cloudflare/circl dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> * ReleaseNotes for v0.3.0-rc.3 --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Gerald Morrison <67469729+morri-son@users.noreply.github.com> Co-authored-by: GitHub Actions Bot <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.11.0 to 0.17.0. - [Commits](golang/net@v0.11.0...v0.17.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: souleb <bah.soule@gmail.com> Co-authored-by: Gerald Morrison <67469729+morri-son@users.noreply.github.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
…s: `ocm-artifact` -> `software.ocm.artifact` and introduce `software.ocm.creator` (open-component-model#987) <!-- markdownlint-disable MD041 --> #### What this PR does / why we need it For OCM repositories based on OCI registries, the manifest now gets an annotation `software.ocm.componentversion` with the component version it represents. The image spec (https://github.com/opencontainers/image-spec/blob/main/annotations.md) state, that annotation names should use a reverse DNS domain prefix. Therefore we should adapt the names of the already existing layer annotations accordingly. This PR prepends the actuals names with `software.ocm.". The old layer annotation changes from `ocm-artifact` -> `software.ocm.artifact`. #### Which issue(s) this PR fixes Fixes open-component-model/ocm-project#190 <!-- Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`. --> Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
matthiasbruns
force-pushed
the
fix/1560_confusing_error_logging
branch
from
2593800 to
f6090c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On-behalf-of: SAP matthias.bruns@sap.com
What this PR does / why we need it
Users complain about confusing error messages in
get cv.Errors that are related to technical problems, like missing docker binaries or other things, are not properly communicated and hidden by a generic
invalid component referencemessage.This PR logs more details in case of technical errors.
Which issue(s) this PR is related to
Fixes: #1560