Skip to content

Conversation

Copy link

Copilot AI commented Jan 27, 2026

Description

The test_cli_v3_scan test only verified the scan command, leaving 4 other legacy v3 commands (scan_status, ingest, test_connection, simulate_anomaly_detection) untested. This creates risk for undetected regressions like typos in command names.

Changes:

  • Parametrized test to verify all 5 legacy v3 commands return exit code 3
  • Renamed test_cli_v3_scantest_cli_v3_legacy_commands for clarity

Checklist

  • I added a test to verify the new functionality.
  • I verified this PR does not break soda-extensions.

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@sonarqubecloud
Copy link

Copy link
Author

Copilot AI commented Jan 27, 2026

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • collect.soda.io
    • Triggering command: /home/REDACTED/work/soda-core/soda-core/.venv/bin/pytest pytest soda-tests/tests/components/test_cli.py::test_cli_v3_legacy_commands -v (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] WIP to address feedback on v3 commands handling in CLI Parametrize legacy v3 command test to cover all commands Jan 27, 2026
Copilot AI requested a review from m1n0 January 27, 2026 10:57
@m1n0 m1n0 marked this pull request as ready for review January 27, 2026 10:59
@m1n0 m1n0 merged commit e728ccf into chore/v3-cli Jan 27, 2026
2 of 3 checks passed
@m1n0 m1n0 deleted the copilot/sub-pr-2547-again branch January 27, 2026 11:00
m1n0 added a commit that referenced this pull request Jan 27, 2026
* Chore: handle v3 commands in CLI

* Update soda-core/src/soda_core/cli/cli.py

Co-authored-by: Copilot <[email protected]>

* Parametrize legacy v3 command test to cover all commands (#2549)

* Initial plan

* Parametrize test to cover all 5 legacy v3 commands

Co-authored-by: m1n0 <[email protected]>

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: m1n0 <[email protected]>

* adjusted link

* Refactor legacy command list to module-level frozenset constant (#2548)

* Initial plan

* Refactor: Move legacy_cmds to module-level constant as frozenset

Co-authored-by: m1n0 <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: m1n0 <[email protected]>
Co-authored-by: Milan Lukac <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* adjusted wording

---------

Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: m1n0 <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants