merge_pr_57376

[WPT] Fix connect-src-webtransport CSP tests

I believe the third test in
connect-src-webtransport-allowed.sub.https.html is supposed to check
that even if a WebTransport connection is initiated specifying some
serverCertificateHashes, the connection is not allowed by CSP unless
CSP contains the new keyword 'unsafe-webtransport-hashes'.

This CL also fixes a minor issue with WPT templating in the tests.

Bug: 477304103
Change-Id: Ifa251a3a314e4cc6eb802f24b92445c847d74049
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7502859
Commit-Queue: Antonio Sartori [email protected]
Reviewed-by: Mike West [email protected]
Cr-Commit-Position: refs/heads/main@{#1575792}

merge_pr_57375

layout: Fixed linebreaking logic when . A better solution would be to use , however doesn't accept any arguments with version yet. TODO: fix the logic once can be upgraded to

Signed-off-by: Richard Tjokroutomo [email protected]

merge_pr_57374

Drop 'portrait' from size descriptor when default

All the named sizes have a size which is portrait by default.

Serialization will be more minimal, and wpt test starts passing.

Bug: 356917017
Change-Id: I2188597890993be0bca1be229f0a3194bd36e5f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7524025
Commit-Queue: Rune Lillesveen [email protected]
Reviewed-by: Morten Stenshorne [email protected]
Cr-Commit-Position: refs/heads/main@{#1575737}

merge_pr_57373

Revert "Implement the CSS image-animation property"

This reverts commit 0383d249f4843bcc19dbb6d201cc76d169c60cd7.

Reason for revert: suspect causing blink_unittests failure on Linux UBSan Test.

blink_unittests failed because of:

• LayoutSelectionTest.TraverseLayoutObjectListStyleImage
• LayoutTextCombineTest.ListItemStyleToImage
• StyleResolverTest.CSSMarkerPseudoElement
• UseCounterImplTest.CSSMarkerPseudoElementUA

First build failure:
https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20UBSan%20Tests/13361/

Original change's description:

Implement the CSS image-animation property

Add support for the CSS image-animation property, which controls the
animated image playback. The property accepts three values:

• normal: Default browser behavior
• running: Per-element timeline
• paused(tentative): Stop animated image

Currently, image animations are managed by ImageAnimationController in
the CC layer. The controller manages the animation information,
including the next frame index and length, ...etc, via PaintImage's
stable_id as a key.

The paint image has been created by BitmapImage::Draw and the image
shared the resource and paint image across the layout and styles if it
has same absolute URL by the WHATWG standard [1].

To pause, we should create new PaintImage with different paint id per
each style.

Therefore, pass the image animation information to the
BitmapImage::Draw() to create different PaintImage by the style. The
BitmapImage class now caches multiple PaintImage instances, which are
keyed by DOM node ID and the animation state. This enables per-element
animation.

Another approach is to duplicate the image resource manually. However,
this approach introduces another caching complexity on several layers.
Therefore, we will not pursue this approach.

Removing "reftest-wait" does not capture the pixels at the exact time on the Mac and it will cause flakiness. Therefore, the exception of -running test suites on Mac has been added to TestExpectations.

[1] https://html.spec.whatwg.org/multipage/rendering.html#images-3

Explainer: https://github.com/webplatformco/project-image-animation/tree/main/image-animation-property
Unofficial Draft: https://webplatform.design/projects/image-animation/image-animation-property/spec/overview
Intent to prototype: https://groups.google.com/a/chromium.org/g/blink-dev/c/0kUk5-6TAfM/m/7YVGLKzEBwAJ
Chromestatus Entry: https://chromestatus.com/feature/5078177326170112

Bug: 429459566
Change-Id: I6e5b6d6cccf6419c7c7c817a7082409e69a9c406
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7458159
Reviewed-by: Anders Hartvoll Ruud [email protected]
Commit-Queue: Seokho Song [email protected]
Reviewed-by: Florin Malita [email protected]
Cr-Commit-Position: refs/heads/main@{#1575651}

Bug: 429459566
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: Ia26f9cef7a639659c289c50fae761fc412839e7c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7526465
Owners-Override: Takashi Sakamoto [email protected]
Commit-Queue: Rubber Stamper [email protected]
Auto-Submit: Takashi Sakamoto [email protected]
Bot-Commit: Rubber Stamper [email protected]
Cr-Commit-Position: refs/heads/main@{#1575715}

merge_pr_57372

Use t.step_timeout in fetch-frame-resource.https.html

Replace setTimeout with t.step_timeout in fetch-frame-resource.https.html
to follow WPT best practices for timer-based tests. This ensures better
integration with the test harness and proper timeout handling.

Bug: w3c/ServiceWorker#1194
Change-Id: I02c796593546fc39f1e44b6c4ac72ee7b2f752e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7509313
Commit-Queue: Yoshisato Yanagisawa [email protected]
Reviewed-by: Marijn Kruisselbrink [email protected]
Cr-Commit-Position: refs/heads/main@{#1575654}

merge_pr_57371

Implement the CSS image-animation property

Add support for the CSS image-animation property, which controls the
animated image playback. The property accepts three values:

• normal: Default browser behavior
• running: Per-element timeline
• paused(tentative): Stop animated image

Currently, image animations are managed by ImageAnimationController in
the CC layer. The controller manages the animation information,
including the next frame index and length, ...etc, via PaintImage's
stable_id as a key.

The paint image has been created by BitmapImage::Draw and the image
shared the resource and paint image across the layout and styles if it
has same absolute URL by the WHATWG standard [1].

To pause, we should create new PaintImage with different paint id per
each style.

Therefore, pass the image animation information to the
BitmapImage::Draw() to create different PaintImage by the style. The
BitmapImage class now caches multiple PaintImage instances, which are
keyed by DOM node ID and the animation state. This enables per-element
animation.

Another approach is to duplicate the image resource manually. However,
this approach introduces another caching complexity on several layers.
Therefore, we will not pursue this approach.

Removing "reftest-wait" does not capture the pixels at the exact time on the Mac and it will cause flakiness. Therefore, the exception of -running test suites on Mac has been added to TestExpectations.

[1] https://html.spec.whatwg.org/multipage/rendering.html#images-3

Explainer: https://github.com/webplatformco/project-image-animation/tree/main/image-animation-property
Unofficial Draft: https://webplatform.design/projects/image-animation/image-animation-property/spec/overview
Intent to prototype: https://groups.google.com/a/chromium.org/g/blink-dev/c/0kUk5-6TAfM/m/7YVGLKzEBwAJ
Chromestatus Entry: https://chromestatus.com/feature/5078177326170112

Bug: 429459566
Change-Id: I6e5b6d6cccf6419c7c7c817a7082409e69a9c406
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7458159
Reviewed-by: Anders Hartvoll Ruud [email protected]
Commit-Queue: Seokho Song [email protected]
Reviewed-by: Florin Malita [email protected]
Cr-Commit-Position: refs/heads/main@{#1575651}

merge_pr_57370

Add missing WPT coverage for CustomElementRegistry.initialize()

There are bugs that are not currently caught by the existing WPT tests
for initialize(). One example is a bug like [1], which does not occur in
Chromium but does occur in WebKit. Since there may be other similar
cases, this change adds missing WPT coverage based on [2].

[1] https://bugs.webkit.org/show_bug.cgi?id=299299
[2] https://html.spec.whatwg.org/multipage/custom-elements.html#dom-customelementregistry-initialize

Bug: 475579177
Change-Id: Ia503db85844b9a08182275a96fe350b07ef08306
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7487391
Reviewed-by: Mason Freed [email protected]
Reviewed-by: Jayson Chen [email protected]
Commit-Queue: YeongHan Kim [email protected]
Cr-Commit-Position: refs/heads/main@{#1575636}

merge_pr_57369

Add fuzz annotation to WPT fragmented-at-start-ignored.html. (#57369)

This test occasionally renders with an imperceptible mismatch
(maxDifference of 1) in the blue area at the bottom-left of the
test. This patch is just annotating that.

merge_pr_57368

Column balancing: Include ruby text in space shortage.

When measuring the fragment block-size when determining whether it fits
in the current column or not, we use BlockSizeForFragmentation(), which
includes space taken up by ruby text (which isn't part of the "raw"
block-size of the fragment). If a fragment is found not to fit, we
calculate space shortage (to stretch the columns and try again). We need
to do the same here, i.e. use BlockSizeForFragmentation() rather than
the "raw" fragment size. Otherwise no shortage will be detected.

One existing test now ends up with a more ideal column height than
before, and has therefore been rebaselined.

Bug: 391504025
Change-Id: Ib8cb5acb2eacec8cd8af8b728d73f85550a0e961
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7510938
Reviewed-by: Ian Kilpatrick [email protected]
Commit-Queue: Morten Stenshorne [email protected]
Cr-Commit-Position: refs/heads/main@{#1575732}

merge_pr_57367

Column balancing: Propagate unbreakable content from floats.

Since we don't have access to the fragment builder during float layout
(because of how inline layout works), extra efforts are required to
propagate the tallest piece of unbreakable content in floats.

Refactor the code a little, so that this can easily be calculated and
propagated on the outside of MovePastBreakpoint().

The new test multicol-fill-balance-032.html turned out to be pretty
similar to the legacy test fast/multicol/balance-float-in-inline.html
(which now would pass), so just remove that one.

Bug: 394900337
Change-Id: I7c9852ca8aacc7edcdbb474973074eb0dd4dba89
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7520768
Reviewed-by: Ian Kilpatrick [email protected]
Commit-Queue: Morten Stenshorne [email protected]
Cr-Commit-Position: refs/heads/main@{#1575785}