-
Notifications
You must be signed in to change notification settings - Fork 69
Update jackson-datatype-jdk8 to 2.21.0 #4149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @xerial-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a routine update of the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the com.fasterxml.jackson.datatype:jackson-datatype-jdk8 dependency from 2.18.5 to 2.21.0. While this is a straightforward version bump, I've noticed that another module from the same group, jackson-datatype-json-org, is not being updated. This could lead to classpath issues. I've added a comment to recommend aligning the versions of all related Jackson modules and suggested using a variable to manage the version centrally.
| // Necessary for td-client-java, which is used in fluency-treasuredata | ||
| "com.fasterxml.jackson.datatype" % "jackson-datatype-json-org" % "2.18.5" % Provided, | ||
| "com.fasterxml.jackson.datatype" % "jackson-datatype-jdk8" % "2.18.5" % Provided, | ||
| "com.fasterxml.jackson.datatype" % "jackson-datatype-jdk8" % "2.21.0" % Provided, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The jackson-datatype-json-org dependency on the previous line is still using version 2.18.5. It is highly recommended to align the versions of all modules from the com.fasterxml.jackson.datatype group to avoid potential classpath conflicts and ensure compatibility. Please consider updating jackson-datatype-json-org to 2.21.0 as well.
To make future updates easier and ensure consistency, you could define a variable for the Jackson version and use it for all related modules:
val JACKSON_DATATYPE_VERSION = "2.21.0"
// ...
"com.fasterxml.jackson.datatype" % "jackson-datatype-json-org" % JACKSON_DATATYPE_VERSION % Provided,
"com.fasterxml.jackson.datatype" % "jackson-datatype-jdk8" % JACKSON_DATATYPE_VERSION % Provided,
About this PR
📦 Updates com.fasterxml.jackson.datatype:jackson-datatype-jdk8 from
2.18.5to2.21.0Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a
.scala-steward.conffile.Have a fantastic day writing Scala!
🔍 Files still referring to the old version number
The following files still refer to the old version number (2.18.5).
You might want to review and update them manually.
⚙ Adjust future updates
Add this to your
.scala-steward.conffile to ignore future updates of this dependency:Or, add this to slow down future updates of this dependency: