Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build.sbt
Original file line number Diff line number Diff line change
Expand Up @@ -976,7 +976,7 @@ lazy val fluentd =
exclude ("junit", "junit"),
// Necessary for td-client-java, which is used in fluency-treasuredata
"com.fasterxml.jackson.datatype" % "jackson-datatype-json-org" % "2.18.5" % Provided,
"com.fasterxml.jackson.datatype" % "jackson-datatype-jdk8" % "2.18.5" % Provided,
"com.fasterxml.jackson.datatype" % "jackson-datatype-jdk8" % "2.21.0" % Provided,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The jackson-datatype-json-org dependency on the previous line is still using version 2.18.5. It is highly recommended to align the versions of all modules from the com.fasterxml.jackson.datatype group to avoid potential classpath conflicts and ensure compatibility. Please consider updating jackson-datatype-json-org to 2.21.0 as well.

To make future updates easier and ensure consistency, you could define a variable for the Jackson version and use it for all related modules:

val JACKSON_DATATYPE_VERSION = "2.21.0"
// ...
"com.fasterxml.jackson.datatype" % "jackson-datatype-json-org" % JACKSON_DATATYPE_VERSION % Provided,
"com.fasterxml.jackson.datatype" % "jackson-datatype-jdk8"     % JACKSON_DATATYPE_VERSION % Provided,

// Redirecting slf4j log from Fluency to aiframe-log
"org.slf4j" % "slf4j-jdk14" % SLF4J_VERSION
)
Expand Down
Loading