-
Notifications
You must be signed in to change notification settings - Fork 791
Add Zvzip extension #2529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add Zvzip extension #2529
Conversation
|
Thanks! As usual, we'll leave this open until ratification. |
d836874 to
736ba6b
Compare
|
Is it intentional that this chapter is not included in the compilation flow? Since it’s not embedded anywhere (e.g., in |
24cc987 to
6b9871d
Compare
I have included it in the build but it may not be the best place to include the chapter. |
815df8d to
307777c
Compare
602d498 to
6e5ee5b
Compare
nibrunie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although it seems all those instructions support optional masking, there are very few information about the masking behavior (in particular which index of mask should be used for each result element in vzip.vv). I am wondering if it could be integrated in the pseudo code or described somewhat.
@nibrunie The pseudocode is updated to include the masking behavior. Please take a look. |
Looks good to me, thank you for making the changes @ved-rivos. |
fe26866 to
7f1dfac
Compare
8212d32 to
3a2672e
Compare
|
@ved-rivos I guess the extension depends on Zve32x, right? If so, I think this should be mentioned. |
The extension depends on the V Extension for Application Processors or the Zve32x Extension for Embedded Processors. I will mention it. |
|
Zve32x is a subset of V, so mentioning Zve32x should be enough. |
Agreed with @nadime15 , V implies Zve32x, so mentioning Zve32x should be enough (Zve64x could be added to extend to SEW=64 case). |
Zvzip standard extension provides instructions for reordering structured data in vector registers. These instruction address usages such as packing and unpacking data structures such as color components of a pixel, real and imaginary components of complex numbers, transposing small matrices, among others.